Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Use unique keys instead of index in map functions #3688

Merged

Conversation

eriwarr
Copy link
Collaborator

@eriwarr eriwarr commented Sep 25, 2024

Description and Motivation

This PR switches from using index as keys in our map() functions to more stable, unique identifiers. This change helps prevent issues related to reordering and ensures our components behave predictably during updates.

closes #3646

Has this been tested? How?

Screenshots (if appropriate)

N/A for this one, as it’s mostly under-the-hood improvements.

Types of changes

  • Refactor/chore

New frontend preview link is below in the Netlify comment 😎

Copy link

netlify bot commented Sep 25, 2024

Deploy Preview for health-equity-tracker ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 86c7198
🔍 Latest deploy log https://app.netlify.com/sites/health-equity-tracker/deploys/66f44bc24856e2000826a54d
😎 Deploy Preview https://deploy-preview-3688--health-equity-tracker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@eriwarr eriwarr self-assigned this Sep 25, 2024
Copy link
Collaborator

@kccrtv kccrtv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks eric! 🥇

@benhammondmusic benhammondmusic merged commit c3a525c into SatcherInstitute:main Sep 25, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Replace key={index} in Mapping with Unique Identifiers
3 participants